linux-kernel - Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160215012021.GG26844@kroah.com>
Date:	Sun, 14 Feb 2016 17:20:21 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Victor Dodon <printesoi@...omium.org>
Cc:	linux-kernel@...r.kernel.org,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG

On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote:
> The US_DEBUGPX macro uses printk without specifying a kernel log level, so
> the default kernel log level is used, which may not match LOGLEVEL_DEBUG
> used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead.
> 
> Signed-off-by: Victor Dodon <printesoi@...omium.org>
> ---
>  drivers/usb/storage/debug.h | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)

Can you just get rid of US_DEBUGPX() entirely please?  It shouldn't be
needed anymore, just use usb_stor_dbg() instead.

thanks,

greg k-h