linux-kernel - [PATCHv2 1/2] fs/pstore: Use memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1455524389-8824-2-git-send-email-enric.balletbo@collabora.com>
Date:	Mon, 15 Feb 2016 09:19:48 +0100
From:	Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:	linux-kernel@...r.kernel.org
Cc:	Anton Vorontsov <anton@...msg.org>,
	Colin Cross <ccross@...roid.com>,
	Kees Cook <keescook@...omium.org>,
	Tony Luck <tony.luck@...el.com>,
	Furquan Shaikh <furquan@...gle.com>,
	Aaron Durbin <adurbin@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	Puneet Kumar <puneetster@...omium.org>,
	tomeu.vizoso@...labora.co.uk, gustavo.padovan@...labora.co.uk,
	emilio.lopez@...labora.co.uk, sjoerd.simons@...labora.co.uk,
	Enric Balletbo Serra <enric.balletbo@...labora.com>
Subject: [PATCHv2 1/2] fs/pstore: Use memcpy_toio instead of memcpy

From: Furquan Shaikh <furquan@...gle.com>

persistent_ram_update uses vmap / iomap based on whether the buffer is in
memory region or reserved region. However, both map it as non-cacheable
memory. For armv8 specifically, non-cacheable mapping requests use a
memory type that has to be accessed aligned to the request size. memcpy()
doesn't guarantee that.

Signed-off-by: Furquan Shaikh <furquan@...gle.com>
Signed-off-by: Enric Balletbo Serra <enric.balletbo@...labora.com>
Reviewed-by: Aaron Durbin <adurbin@...omium.org>
Reviewed-by: Olof Johansson <olofj@...omium.org>
Tested-by: Furquan Shaikh <furquan@...omium.org>
Acked-by: Kees Cook <keescook@...omium.org>
---
 fs/pstore/ram_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 76c3f80..351164d 100644
--- a/fs/pstore/ram_core.c
+++ b/fs/pstore/ram_core.c
@@ -299,7 +299,7 @@ static void notrace persistent_ram_update(struct persistent_ram_zone *prz,
 	const void *s, unsigned int start, unsigned int count)
 {
 	struct persistent_ram_buffer *buffer = prz->buffer;
-	memcpy(buffer->data + start, s, count);
+	memcpy_toio(buffer->data + start, s, count);
 	persistent_ram_update_ecc(prz, start, count);
 }
 
-- 
2.1.0