linux-kernel - Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C18C07.2030209@huawei.com>
Date:	Mon, 15 Feb 2016 16:27:51 +0800
From:	Hanjun Guo <guohanjun@...wei.com>
To:	Mark Brown <broonie@...nel.org>, qiujiang <qiujiang@...wei.com>
CC:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	<charles.chenxin@...wei.com>, <linuxarm@...wei.com>,
	<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	<linux-spi@...r.kernel.org>
Subject: Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware
 SPI driver

On 2016/2/5 19:09, Mark Brown wrote:
> On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote:
>
>> This patch added ACPI support for DesignWare SPI mmio driver. It
>> was based the corresponding DT driver and compatible for this two
>> way. This patch has been tested on Hisilicon D02 board. It relies
>> on the GPIO patchset.
> Intel are heavy users of this driver on their systems which also use
> ACPI.  Have you discussed this binding with them?  I've copied Andy and
> Jarkko who've worked on the driver recently.

There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
this driver directly.

[...]
>
>> +static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
>> +		{"HISI0171", 0},
>> +		{ }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> I really do wish ACPI had some more sensible system for allocating
> device IDs so the tables were a little more legible. :(

Hmm, I agree. but for now, every OEM can request ACPI or PNP ID with specific
prefixes, and they can manage it by themselves, that would flexible for OEM verdors
to develop firmware and driver.

For this driver in particular, if DesignWare provides the ACPI or PNP ID, that would
be great for all OEMs can reuse it.

Thanks
Hanjun