| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGb2v67Wz1EC4=ffZgYPXHiYenwbcbTypqaC3TcP96G1APiNog@mail.gmail.com>
Date: Mon, 15 Feb 2016 17:55:49 +0800
From: Chen-Yu Tsai <wens@...e.org>
To: Chen-Yu Tsai <wens@...e.org>
Cc: Vishnu Patekar <vishnupatekar0510@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Jonathan Corbet <corbet@....net>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Maxime Ripard <maxime.ripard@...e-electrons.com>,
Russell King - ARM Linux <linux@....linux.org.uk>,
Emilio Lopez <emilio@...pez.com.ar>,
Jens Kuske <jenskuske@...il.com>,
Hans De Goede <hdegoede@...hat.com>,
devicetree <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-sunxi <linux-sunxi@...glegroups.com>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...eaurora.org>,
Reinder de Haan <patchesrdh@...as.com>,
linux-clk <linux-clk@...r.kernel.org>
Subject: Re: [PATCH 10/14] ARM: dts: sun8i-a83t: Add PRCM related clocks and resets
On Mon, Feb 15, 2016 at 5:34 PM, Chen-Yu Tsai <wens@...e.org> wrote:
> On Sat, Feb 13, 2016 at 12:43 AM, Chen-Yu Tsai <wens@...e.org> wrote:
>> On Sat, Feb 13, 2016 at 12:06 AM, Vishnu Patekar
>> <vishnupatekar0510@...il.com> wrote:
>>> Hello Wens,
>>>
>>>
>>> On Tue, Feb 2, 2016 at 2:44 PM, Chen-Yu Tsai <wens@...e.org> wrote:
>>>> On Sun, Jan 31, 2016 at 9:21 AM, Vishnu Patekar
>>>> <vishnupatekar0510@...il.com> wrote:
>>>>> This adds A83T PRCM related clocks, clock resets.
>>>>>
>>>>> As a83t apb0 gates clock support is added earlier, this enables it.
>>>>> Apart from apb0 gates, other added clocks are compatible with
>>>>> earlier sun8i socs.
>>>>>
>>>>> Signed-off-by: Vishnu Patekar <vishnupatekar0510@...il.com>
>>>>> ---
>>>>> arch/arm/boot/dts/sun8i-a83t.dtsi | 44 +++++++++++++++++++++++++++++++++++++++
>>>>> 1 file changed, 44 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
>>>>> index ac96aa1..5ea20ff 100644
>>>>> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
>>>>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
>>>>> @@ -268,6 +268,44 @@
>>>>> "mmc2_output",
>>>>> "mmc2_sample";
>>>>> };
>>>>> +
>>>>> + cpus_clk: clk@...01400 {
>>>>> + compatible = "allwinner,sun9i-a80-cpus-clk";
>>>>> + reg = <0x01f01400 0x4>;
>>>>> + #clock-cells = <0>;
>>>>> + clocks = <&osc16Md512>, <&osc24M>, <&pll6>, <&osc16M>;
>>>>> + clock-output-names = "cpus";
>>>>> + };
>>>>> +
>>>>> + ahb0: ahb0_clk {
>>>>> + compatible = "fixed-factor-clock";
>>>>> + #clock-cells = <0>;
>>>>> + clock-div = <1>;
>>>>> + clock-mult = <1>;
>>>>> + clocks = <&cpus_clk>;
>>>>> + clock-output-names = "ahb0";
>>>>> + };
>>>>> +
>>>>> + apb0: clk@...0140c {
>>>>> + compatible = "allwinner,sun8i-a23-apb0-clk";
>>>>
>>>> This is actually wrong, as it is wrong in sun9i-a80.dtsi.
>>>> I've sent a patch series for it.
>>> A83T apb0 is different from A80, and it's same as A23, so this should
>>> be correct.
>>> Please correct me in case I'm missing something.
>>
>> My user manual (v1.5.1) says A83T apb0 dividers (page. 246) are
>> /1, /2, /3, /4, while the A23 is /1, /2, /4, /8.
>
> As Vishnu pointed out on IRC, the A23 driver is wrong. They are in fact,
> both one-based dividers. I'll send a patch to fix this.
^^^
zero-based
And for this patch,
Acked-by: Chen-Yu Tsai <wens@...e.org>
>
> ChenYu
>
>> ChenYu
>>
>>>> Also the drivers for "allwinner,sun9i-a80-cpus-clk" and
>>>> "allwinner,sun9i-a80-apbs-clk"
>>>> are only compiled for CONFIG_MACH_SUN9I. Please add a patch to address this.
>>> Okie.
>>>>
>>>> Regards
>>>> ChenYu
>>>>
>>>>> + reg = <0x01f0140c 0x4>;
>>>>> + #clock-cells = <0>;
>>>>> + clocks = <&ahb0>;
>>>>> + clock-output-names = "apb0";
>>>>> + };
>>>>> +
>>>>> + apb0_gates: clk@...01428 {
>>>>> + compatible = "allwinner,sun8i-a83t-apb0-gates-clk";
>>>>> + reg = <0x01f01428 0x4>;
>>>>> + #clock-cells = <1>;
>>>>> + clocks = <&apb0>;
>>>>> + clock-indices = <0>, <1>,
>>>>> + <2>, <3>,
>>>>> + <4>, <6>, <7>;
>>>>> + clock-output-names = "apb0_pio", "apb0_ir",
>>>>> + "apb0_timer", "apb0_rsb",
>>>>> + "apb0_uart", "apb0_i2c0", "apb0_twd";
>>>>> + };
>>>>> };
>>>>>
>>>>> soc {
>>>>> @@ -434,5 +472,11 @@
>>>>> #interrupt-cells = <3>;
>>>>> interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_HIGH)>;
>>>>> };
>>>>> +
>>>>> + apb0_reset: reset@...014b0 {
>>>>> + reg = <0x01f014b0 0x4>;
>>>>> + compatible = "allwinner,sun6i-a31-clock-reset";
>>>>> + #reset-cells = <1>;
>>>>> + };
>>>>> };
>>>>> };
>>>>> --
>>>>> 1.9.1
>>>>>
Powered by blists - more mailing lists