linux-kernel - Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C1C95E.7030002@osg.samsung.com>
Date:	Mon, 15 Feb 2016 09:49:34 -0300
From:	Javier Martinez Canillas <javier@....samsung.com>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Cc:	k.kozlowski.k@...il.com, devicetree@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Rob Herring <robh+dt@...nel.org>,
	Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT
 binding

Hello Krzysztof,

Thanks a lot for your feedback.

On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote:
> W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze:
>> The S3C Real Time Clock driver requires the clock and source clock to
>> be defined in the device node but that requirement is not documented.
>
> +Cc: Alessandro Zummo
>

I didn't add Alessandro to cc deliberately since Alexandre is the one
maintaining the RTC subsystem lately and before that, the RTC patches
were picked by Andrew Morton since Alessandro didn't even answer the
emails.

> No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks
> but rest of compatible devices need only rtc clock.
>

Right, sorry for missing that. I noticed that this patch has already
been picked by Rob Herring (I thought it would be picked by Alexandre
though) so I will post a follow up patch explaining that rtc_src is
only for the s3c6410-rtc compatible.

> Best regards,
> Krzysztof
>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America