[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <1455546925-22119-6-git-send-email-a.hajda@samsung.com>
Date: Mon, 15 Feb 2016 15:35:23 +0100
From: Andrzej Hajda <a.hajda@...sung.com>
To: linux-kernel@...r.kernel.org
Cc: Andrzej Hajda <a.hajda@...sung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>,
Alexander Shiyan <shc_work@...l.ru>,
linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: [PATCH 5/7] serial: clps711x: fix IS_ERR_VALUE usage
IS_ERR_VALUE macro should be used only with unsigned long type.
For signed types comparison 'ret < 0' should be used.
The patch follows conclusion from discussion on LKML [1][2].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2120927
[2]: http://permalink.gmane.org/gmane.linux.kernel/2150581
Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
---
drivers/tty/serial/clps711x.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/clps711x.c b/drivers/tty/serial/clps711x.c
index b3a4e0c..0096ebe 100644
--- a/drivers/tty/serial/clps711x.c
+++ b/drivers/tty/serial/clps711x.c
@@ -467,13 +467,15 @@ static int uart_clps711x_probe(struct platform_device *pdev)
if (IS_ERR(s->port.membase))
return PTR_ERR(s->port.membase);
- s->port.irq = platform_get_irq(pdev, 0);
- if (IS_ERR_VALUE(s->port.irq))
- return s->port.irq;
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
+ return ret;
+ s->port.irq = ret;
- s->rx_irq = platform_get_irq(pdev, 1);
- if (IS_ERR_VALUE(s->rx_irq))
- return s->rx_irq;
+ ret = platform_get_irq(pdev, 1);
+ if (ret < 0)
+ return ret;
+ s->rx_irq = ret;
if (!np) {
char syscon_name[9];
--
1.9.1
Powered by blists - more mailing lists