[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <56C119BE.8000608@rock-chips.com>
Date: Mon, 15 Feb 2016 08:20:14 +0800
From: Shawn Lin <shawn.lin@...k-chips.com>
To: Jaehoon Chung <jh80.chung@...sung.com>,
Ulf Hansson <ulf.hansson@...aro.org>
Cc: shawn.lin@...k-chips.com, shawn.lin@...nel-upstream.org,
linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR
Hi Jaehoon,
On 2016/2/15 6:29, Jaehoon Chung wrote:
> On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
>> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>>> Hi, Shawn.
>>>>
>>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>>> remove it.
>>>>
>>>> If you are ok, after changing the commit message, I will apply this.
>>>> Thanks!
>>>
>>> Should I respin v2 to amend the commit msg? :-)
>>
>> Not important..but i want to use this. :)
>> "we can remove it" -> "It can be removed."
>
yes, please.
> One more..This patch is [1/2]..I didn't see the second patch [2/2].
Only one patch here, no [2/2]. sorry for the noise
>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>>
>>>>>
>>>>> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
>>>>> ---
>>>>>
>>>>> include/linux/mmc/dw_mmc.h | 1 -
>>>>> 1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>>> index 89df7ab..b29e06e 100644
>>>>> --- a/include/linux/mmc/dw_mmc.h
>>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>>> @@ -36,7 +36,6 @@ enum {
>>>>> EVENT_XFER_COMPLETE,
>>>>> EVENT_DATA_COMPLETE,
>>>>> EVENT_DATA_ERROR,
>>>>> - EVENT_XFER_ERROR
>>>>> };
>>>>>
>>>>> struct mmc_data;
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
>
>
--
Best Regards
Shawn Lin
Powered by blists - more mailing lists