linux-kernel - Re: [PATCH v11 1/1] efi: a misc char interface for user to update efi firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 15 Feb 2016 08:41:06 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>,
	Ong Boon Leong <boon.leong.ong@...el.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-efi@...r.kernel.org,
	Sam Protsenko <semen.protsenko@...aro.org>,
	Peter Jones <pjones@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Roy Franz <roy.franz@...aro.org>,
	Borislav Petkov <bp@...en8.de>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>,
	Anvin H Peter <h.peter.anvin@...el.com>
Subject: Re: [PATCH v11 1/1] efi: a misc char interface for user to update
 efi firmware

On Mon, Feb 08, 2016 at 09:50:03AM +0000, Matt Fleming wrote:
> On Sun, 07 Feb, at 09:43:31PM, Greg KH wrote:
> > On Fri, Jan 29, 2016 at 12:39:54PM +0800, Kweh, Hock Leong wrote:
> > > From: "Kweh, Hock Leong" <hock.leong.kweh@...el.com>
> > > 
> > > Introducing a kernel module to expose capsule loader interface
> > > (misc char device file note) for users to upload capsule binaries.
> > > 
> > > Example:
> > > cat firmware.bin > /dev/efi_capsule_loader
> > > 
> > > This patch also export efi_capsule_supported() function symbol for
> > > verifying the submitted capsule header in this kernel module.
> > > 
> > > Cc: Matt Fleming <matt@...eblueprint.co.uk>
> > > Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@...el.com>
> > > ---
> > >  drivers/firmware/efi/Kconfig          |    9 +
> > >  drivers/firmware/efi/Makefile         |    1 +
> > >  drivers/firmware/efi/capsule-loader.c |  334 +++++++++++++++++++++++++++++++++
> > >  drivers/firmware/efi/capsule.c        |    1 +
> > >  4 files changed, 345 insertions(+)
> > >  create mode 100644 drivers/firmware/efi/capsule-loader.c
> > 
> > I need an ack from the efi maintainer, or at least someone else
> > reviewing / testing this, before I can accept it.
> 
> Thanks Greg, but this should probably go through the EFI tree since
> there are prerequisite core EFI capsule patches for this driver.
> 
> If you're happy with the code though, an ACK would be much
> appreciated.

Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>