linux-kernel - Re: [PATCH] Bluetooth: hci_uart: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455556178.4046.14.camel@perches.com>
Date:	Mon, 15 Feb 2016 09:09:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	kbuild test robot <lkp@...el.com>,
	Amitkumar Karwar <akarwar@...vell.com>
Cc:	kbuild-all@...org, linux-bluetooth@...r.kernel.org,
	Nishant Sarmukadam <nishants@...vell.com>,
	linux-kernel@...r.kernel.org, Cathy Luo <cluo@...vell.com>,
	marcel@...tmann.org, Ganapathi Bhat <gbhat@...vell.com>
Subject: Re: [PATCH] Bluetooth: hci_uart: fix boolreturn.cocci warnings

On Tue, 2016-02-16 at 00:25 +0800, kbuild test robot wrote:
> drivers/bluetooth/hci_mrvl.c:411:9-10: WARNING: return of 0/1 in
> function 'mrvl_fw_loaded' with return type bool
> 
>  Return statements in functions returning bool should use
>  true/false instead of 1/0.
> Generated by: scripts/coccinelle/misc/boolreturn.cocci
> 
> CC: Ganapathi Bhat <gbhat@...vell.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  hci_mrvl.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/drivers/bluetooth/hci_mrvl.c
> +++ b/drivers/bluetooth/hci_mrvl.c
> @@ -408,9 +408,9 @@ static bool mrvl_fw_loaded(struct hci_ua
>  	struct fw_data *fw_data = mrvl->fwdata;
>  
>  	if ((get_cts(hu->tty)) || (fw_data->fw_loaded))
> -		return 1;
> +		return true;
>  	else
> -		return 0;
> +		return false;
>  }

Nicer might be

	return get_cts(hu->tty) || fw_data->fw_loaded;
 
>  /* Set the baud rate */