linux-kernel - Re: [PATCH] xfs: fix format specifier , should be %llx and not %llu

Open Source and information security mailing list archives

Date:	Mon, 15 Feb 2016 13:57:23 -0500
From:	Brian Foster <bfoster@...hat.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Dave Chinner <david@...morbit.com>, xfs@....sgi.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs:  fix format specifier , should be %llx and not %llu

On Sat, Feb 13, 2016 at 08:26:22PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> busyp->bno is printed with a %llu format specifier when the
> intention is to print a hexadecimal value. Trivial fix to
> use %llx instead.  Found with smatch static analysis:
> 
> fs/xfs/xfs_discard.c:229 xfs_discard_extents() warn: '0x'
>   prefix is confusing together with '%llu' specifier
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Reviewed-by: Brian Foster <bfoster@...hat.com>

>  fs/xfs/xfs_discard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
> index e85a951..272c3f8 100644
> --- a/fs/xfs/xfs_discard.c
> +++ b/fs/xfs/xfs_discard.c
> @@ -227,7 +227,7 @@ xfs_discard_extents(
>  				GFP_NOFS, 0);
>  		if (error && error != -EOPNOTSUPP) {
>  			xfs_info(mp,
> -	 "discard failed for extent [0x%llu,%u], error %d",
> +	 "discard failed for extent [0x%llx,%u], error %d",
>  				 (unsigned long long)busyp->bno,
>  				 busyp->length,
>  				 error);
> -- 
> 2.7.0
> 
> _______________________________________________
> xfs mailing list
> xfs@....sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives