linux-kernel - Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160215193613.GB13054@kroah.com>
Date:	Mon, 15 Feb 2016 11:36:13 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Michael Welling <mwelling@...e.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Neil Armstrong <narmstrong@...libre.com>,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH 4.3 041/200] spi: omap2-mcspi: disable other channels
 CHCONF_FORCE in prepare_message

On Mon, Feb 15, 2016 at 12:50:41PM -0600, Michael Welling wrote:
> On Mon, Feb 15, 2016 at 10:15:08AM -0800, Greg Kroah-Hartman wrote:
> > On Sun, Feb 14, 2016 at 09:08:50PM -0600, Michael Welling wrote:
> > > On Sun, Feb 14, 2016 at 03:17:36PM -0800, Greg Kroah-Hartman wrote:
> > > > On Sun, Feb 14, 2016 at 04:50:47PM -0600, Michael Welling wrote:
> > > > > On Sun, Feb 14, 2016 at 02:20:48PM -0800, Greg Kroah-Hartman wrote:
> > > > > > 4.3-stable review patch.  If anyone has any objections, please let me know.
> > > > > >
> > > > > 
> > > > > If not planned it should be considered that we include the latest two
> > > > > commits to spi-omap2-mcpsi into stable as well.
> > > > > 
> > > > > spi: omap2-mcspi: Prevent duplicate gpio_request
> > > > > spi: omap2-mcspi: Add calls for pinctrl state select 
> > > > > 
> > > > > Let me know if I need to do anything to make this happen.
> > > > 
> > > > What are the git commit ids of them?
> > > 
> > > commit 2f538c017e1a8620d19553931199c6d6a6d31bb2
> > > Author: Michael Welling <mwelling@...e.org>
> > > Date:   Mon Nov 30 09:02:39 2015 -0600
> > > 
> > >     spi: omap2-mcspi: Prevent duplicate gpio_request
> > >     
> > >     Occasionally the setup function will be called multiple times. Only request
> > >     the gpio the first time otherwise -EBUSY will occur on subsequent calls to
> > >     setup.
> > >     
> > >     Reported-by: Joseph Bell <joe@...hieved.it>
> > >     
> > >     Signed-off-by: Michael Welling <mwelling@...e.org>
> > >     Signed-off-by: Mark Brown <broonie@...nel.org>
> > 
> > That seems reasonable but:
> > 
> > > commit beca365565d8f8912dce67567f54ad4c71734843
> > > Author: Pascal Huerst <pascal.huerst@...il.com>
> > > Date:   Thu Nov 19 16:18:28 2015 +0100
> > > 
> > >     spi: omap2-mcspi: Add calls for pinctrl state select
> > >     
> > >     This adds calls to pinctrl subsystem in order to switch pin states
> > >     on suspend/resume if you provide a "sleep" state in DT.
> > >     
> > >     If no "sleep" state is provided in DT, these calls turn
> > >     to NOPs.
> > >     
> > >     Signed-off-by: Pascal Huerst <pascal.huerst@...il.com>
> > >     Signed-off-by: Mark Brown <broonie@...nel.org>
> > 
> > That looks like a new feature being added.
> > 
> > > > What stable tree(s) do you want
> > > > them applied to?
> > > 
> > > v4.3, v4.4
> > 
> > 4.3 is now end-of-life with this release, can you live with these just
> > in 4.4-stable instead?
> 
> v4.4 stable is good enough.
> 
> Let me know what needs to be done if anything.

That last patch does not seem like it follows the rules documented at
Documentation/stable_kernel_rules.txt, so I can't take it.