linux-kernel - Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160215195948.GF1640@darkstar.musicnaut.iki.fi>
Date:	Mon, 15 Feb 2016 21:59:48 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Heinrich Schuchardt <xypron.glpk@....de>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Andrew Bresticker <abrestic@...omium.org>,
	devicetree@...r.kernel.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] MIPS: DTS: cavium-octeon: provide model attribute

Hi,

On Mon, Feb 15, 2016 at 08:50:48PM +0100, Heinrich Schuchardt wrote:
> On 02/15/2016 08:40 PM, Aaro Koskinen wrote:
> > On Mon, Feb 15, 2016 at 08:21:33PM +0100, Heinrich Schuchardt wrote:
> >> flash-kernel has a database /usr/share/flash-kernel/db/all.db with
> >> entries like:
> >>
> >> Machine: LeMaker Banana Pi
> >> Kernel-Flavors: armmp armmp-lpae
> >> Boot-Script-Path: /boot/boot.scr
> >> DTB-Id: sun7i-a20-bananapi.dtb
> >> U-Boot-Script-Name: bootscr.sunxi
> >> Required-Packages: u-boot-tools
> >>
> >> Machine refers to the value of /proc/device-tree/model.
> >> DTB-Id is the dtb to be installed.
> >>
> >> So what flash-kernel does is:
> >> - look up value of /proc/device-tree/model
> >> - retrieve correlated dtb file name from database
> >> - install dtb with this name
> >> - create symbolic links for the dtb
> >>
> >> If multiple boards use the the same dtb that is fine with flash-kernel
> >> as long as the value of model is unique per dtb.
> > 
> > OCTEON does not work like this. The file you are modifying
> > (octeon_3xxx.dts) is compiled into the kernel, and there is no external
> > DTB file. So the model string will be always the same regardless on
> > which board you have booted the kernel.
> 
> you are right DTBs are built in for MIPS systems.
> 
> Still it would be useful to be able to use the same property 'model' to
> determine which u-boot script (boot.scr) to install.

But that cannot be solved by adding a static model string to
octeon_3xxx.dts, because different OCTEON boards need different u-boot
commands (some boot from flash, some from mmc, some from USB, etc.).

A.