linux-kernel - Re: [PATCH] usb: check for signals in chaoskey read function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1455611093.4532.2.camel@suse.com>
Date:	Tue, 16 Feb 2016 09:24:53 +0100
From:	Oliver Neukum <oneukum@...e.com>
To:	Keith Packard <keithp@...thp.com>
Cc:	linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: check for signals in chaoskey read function

On Mon, 2016-02-15 at 18:49 -0800, Keith Packard wrote:
> Call signal_pending before reading a chunk of data from the device so
> that long read operations can be interrupted with a signal.

Hi,

why is this needed? You are doing this right after a
mutex_lock_interruptible().

	Regards
		Oliver