linux-kernel - [PATCH] x86/msr: Document msr-index.h rule for addition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 09:39:37 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	alex.williamson@...hat.com, gleb@...nel.org, joro@...tes.org,
	kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
	sherry.hurwitz@....com,
	Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>,
	wei@...hat.com, x86-ml <x86@...nel.org>
Subject: [PATCH] x86/msr: Document msr-index.h rule for addition

From: Borislav Petkov <bp@...e.de>

In order to keep this file's size sensible and not cause too much
unnecessary churn, make the rule explicit - similar to pci_ids.h - that
only MSRs which are used in multiple compilation units, should get added
to it.

Signed-off-by: Borislav Petkov <bp@...e.de>
Acked-by: Ingo Molnar <mingo@...nel.org>
Cc: alex.williamson@...hat.com
Cc: gleb@...nel.org
Cc: joro@...tes.org
Cc: kvm@...r.kernel.org
CC: Paolo Bonzini <pbonzini@...hat.com>
Cc: sherry.hurwitz@....com
Cc: Suravee Suthikulpanit <Suravee.Suthikulpanit@....com>
Cc: wei@...hat.com
Cc: x86-ml <x86@...nel.org>
---
 arch/x86/include/asm/msr-index.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
index b05402ef3b84..984ab75bf621 100644
--- a/arch/x86/include/asm/msr-index.h
+++ b/arch/x86/include/asm/msr-index.h
@@ -1,7 +1,12 @@
 #ifndef _ASM_X86_MSR_INDEX_H
 #define _ASM_X86_MSR_INDEX_H
 
-/* CPU model specific register (MSR) numbers */
+/*
+ * CPU model specific register (MSR) numbers.
+ *
+ * Do not add new entries to this file unless the definitions are shared
+ * between multiple compilation units.
+ */
 
 /* x86-64 specific MSRs */
 #define MSR_EFER		0xc0000080 /* extended feature register */
-- 
2.3.5