linux-kernel - Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 12:01:16 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Vladimir Murzin <vladimir.murzin@....com>
Cc:	linux@....linux.org.uk, gregkh@...uxfoundation.org,
	daniel.lezcano@...aro.org, tglx@...utronix.de,
	u.kleine-koenig@...gutronix.de, mark.rutland@....com,
	pawel.moll@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, jslaby@...e.cz, robh+dt@...nel.org,
	andy.shevchenko@...il.com, devicetree@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-api@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386

On Tuesday 16 February 2016 10:08:14 Vladimir Murzin wrote:
> +
> +       ethernet@...00000 {
> +               compatible = "smsc,lan9220", "smsc,lan9115";
> +               reg = <0x40200000 0x10000>;
> +               interrupts = <13>;
> +               interrupt-parent = <&nvic>;
> +               smsc,irq-active-high;
> +       };
> +};
> +
> 

This node seems slightly misplaced. Is there some external bus interface
that this is connected to? The address suggests that it should be somewhere
below the /soc node, and you probably want to list the external bus
interface with a "ranges" property that identifies the addresses visibile
there, and put the external chip under there.

	Arnd