linux-kernel - Re: [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160216143648.GB6286@danjae.kornet>
Date:	Tue, 16 Feb 2016 23:36:48 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Stephane Eranian <eranian@...gle.com>,
	linux-kernel@...r.kernel.org, peterz@...radead.org, mingo@...e.hu,
	ak@...ux.intel.com, kan.liang@...el.com, jolsa@...hat.com,
	adrian.hunter@...el.com, dsahern@...il.com
Subject: Re: [PATCH] perf/jvmti: add check for java alternatives cmd in
 Makefile

Hi Arnaldo and Stephane,

On Tue, Feb 16, 2016 at 12:31:26PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Tue, Feb 16, 2016 at 07:37:41AM +0100, Stephane Eranian escreveu:
> > This patch modifies the jvmti makefile to check
> > if /usr/sbin/java-update-alternatives is present.
> > If so, then use it, if not then use the altenatives
> > command. This helps handle the difference between
> > Ubuntu and Fedora Linux distributions.
> 
> Thanks, tested and applied.
> 
> We need tho to better integrate it with the 'make install' target, so
> that it gets built and installed, this way it will end up packaged by
> distros.
> 
> That, together with documentation should be enough as a first step to
> ease usage in a more widespread way.

It'd be better providing a reasonable default (if possible) or guide
to how to setup the JDIR for other distro as well.

Thanks,
Namhyung