linux-kernel - Re: [PATCH v12 1/4] Documentation: add sbsa-gwdt driver documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 07:30:39 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	fu.wei@...aro.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, wim@...ana.be, corbet@....net,
	catalin.marinas@....com, will.deacon@....com,
	Suravee.Suthikulpanit@....com
Cc:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	linux-doc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linaro-acpi@...ts.linaro.org,
	rruigrok@...eaurora.org, harba@...eaurora.org, cov@...eaurora.org,
	timur@...eaurora.org, dyoung@...hat.com, panand@...hat.com,
	graeme.gregory@...aro.org, al.stone@...aro.org,
	hanjun.guo@...aro.org, jcm@...hat.com, arnd@...db.de,
	leo.duran@....com, sudeep.holla@....com
Subject: Re: [PATCH v12 1/4] Documentation: add sbsa-gwdt driver documentation

On 02/16/2016 12:36 AM, fu.wei@...aro.org wrote:
> From: Fu Wei <fu.wei@...aro.org>
>
> The sbsa-gwdt.txt documentation in devicetree/bindings/watchdog is for
> introducing SBSA(Server Base System Architecture) Generic Watchdog
> device node info into FDT.
>
> Also add sbsa-gwdt introduction in watchdog-parameters.txt
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Fu Wei <fu.wei@...aro.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   .../devicetree/bindings/watchdog/sbsa-gwdt.txt     | 31 ++++++++++++++++++++++
>   Documentation/watchdog/watchdog-parameters.txt     |  7 +++++
>   2 files changed, 38 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
> new file mode 100644
> index 0000000..6f2d5f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt
> @@ -0,0 +1,31 @@
> +* SBSA (Server Base System Architecture) Generic Watchdog
> +
> +The SBSA Generic Watchdog Timer is used to force a reset of the system
> +after two stages of timeout have elapsed.  A detailed definition of the
> +watchdog timer can be found in the ARM document: ARM-DEN-0029 - Server
> +Base System Architecture (SBSA)
> +
> +Required properties:
> +- compatible: Should at least contain "arm,sbsa-gwdt".
> +
> +- reg: Each entry specifies the base physical address of a register frame
> +  and the length of that frame; currently, two frames must be defined,
> +  in this order:
> +  1: Watchdog control frame;
> +  2: Refresh frame.
> +
> +- interrupts: Should contain the Watchdog Signal 0 (WS0) SPI (Shared
> +  Peripheral Interrupt) number of SBSA Generic Watchdog.
> +
> +Optional properties
> +- timeout-sec: Watchdog timeout values (in seconds).
> +
> +Example for FVP Foundation Model v8:
> +
> +watchdog@...40000 {
> +	compatible = "arm,sbsa-gwdt";
> +	reg = <0x0 0x2a440000 0 0x1000>,
> +	      <0x0 0x2a450000 0 0x1000>;
> +	interrupts = <0 27 4>;
> +	timeout-sec = <30>;
> +};
> diff --git a/Documentation/watchdog/watchdog-parameters.txt b/Documentation/watchdog/watchdog-parameters.txt
> index 9f9ec9f..ce7ae4e 100644
> --- a/Documentation/watchdog/watchdog-parameters.txt
> +++ b/Documentation/watchdog/watchdog-parameters.txt
> @@ -284,6 +284,13 @@ sbc_fitpc2_wdt:
>   margin: Watchdog margin in seconds (default 60s)
>   nowayout: Watchdog cannot be stopped once started
>   -------------------------------------------------
> +sbsa_gwdt:
> +timeout: Watchdog timeout in seconds. (default 10s)
> +action: Watchdog action at the first stage timeout,
> +	set to 0 to ignore, 1 to panic. (default=0)
> +nowayout: Watchdog cannot be stopped once started
> +	(default=kernel config parameter)
> +-------------------------------------------------
>   sc1200wdt:
>   isapnp: When set to 0 driver ISA PnP support will be disabled (default=1)
>   io: io port
>