linux-kernel - Re: [PATCHv3 5/5] perf tools: Add perf data cache feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160216154829.GE17690@kernel.org>
Date:	Tue, 16 Feb 2016 12:48:29 -0300
From:	Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Namhyung Kim <namhyung@...nel.org>, Jiri Olsa <jolsa@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCHv3 5/5] perf tools: Add perf data cache feature

Em Tue, Feb 16, 2016 at 12:29:36PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Feb 16, 2016 at 04:01:43PM +0100, Jiri Olsa escreveu:
> > +	caches = zalloc(sizeof(struct cache_level) * cnt);
> > +	if (!caches)
> > +		return -1;
> > +
> > +	for (i = 0; i < cnt; i++) {
> > +		struct cache_level c;
> > +
> > +		#define _R(v)						\
> > +			if (readn(fd, &c.v, sizeof(u32)) != sizeof(u32))\
> > +				return -1;				\
> 
> So in this case that 'caches' variable leaks?
> 

Ok, I fixed this and did the rename to cpu_cache_level, tested and
merged it, going to the next patchkit.

Thanks! Useful feature, we should use it in other places, like: record
same workload in different machines, say Ivy Bridge and Broadwell, do
'perf diff' and see the CPU cache topology difference in addition to
other symbolic, per DSO, etc diffs.

- Arnaldo