linux-kernel - Re: [PATCH resend] video: Use bool instead int pointer for get_opt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C347BC.7000005@bmw-carit.de>
Date:	Tue, 16 Feb 2016 17:01:00 +0100
From:	Daniel Wagner <daniel.wagner@...-carit.de>
To:	Tomi Valkeinen <tomi.valkeinen@...com>,
	Maik Broemme <mbroemme@...sserver.de>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH resend] video: Use bool instead int pointer for
 get_opt_bool() argument

On 02/16/2016 02:14 PM, Tomi Valkeinen wrote:
> 
> On 09/02/16 11:18, Daniel Wagner wrote:
>> As the function name already indicates that get_opt_bool() parses
>> for a bool. It is not a surprise that compiler is complaining
>> about it when -Werror=incompatible-pointer-types is used:
>>
>> drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’:
>> drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>>    if (get_opt_bool(this_opt, "accel", &accel))
>>
>> Signed-off-by: Daniel Wagner <daniel.wagner@...-carit.de>
>> Reported-by: Fengguang Wu <fengguang.wu@...el.com>
>> ---
>> [resend because Maik's emial address bounced last try]
>>
>> Hi,
>>
>> In the 'simple wait queue support' series is a patch
>> which turns on -Werror=incompatible-pointer-types which will
>> result in a compile error for intelfb.
>>
>> https://lkml.org/lkml/2016/1/28/462
>>
>> Even if that patch wont make it, this one makes sense (at least
>> for me :))
>>
>> I'll prepend this patch to the next version of the series in order
>> to see if I got rid of all incompatible pointer types errors caught
>> by the kbuild test robot.
> 
> The patch looks good to me, but I didn't quite catch the above. So do
> you want me to apply this to fbdev tree, or do you need to take this via
> some other tree? If the latter, you have my ack.

I don't have any preference on the routing. So if you take it via fbdev
that would be nice. One thing less to care about :)

thanks,
daniel