linux-kernel - Re: [PATCH 2/2] ARM: mm: hide __start_rodata_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4716656.D1MJCNd1N6@wuerfel>
Date:	Tue, 16 Feb 2016 17:34:30 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Russell King <linux@....linux.org.uk>,
	Kees Cook <keescook@...omium.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Brandt <chris.brandt@...esas.com>,
	Laura Abbott <labbott@...oraproject.org>
Subject: Re: [PATCH 2/2] ARM: mm: hide __start_rodata_section_aligned for non-debug builds

On Tuesday 16 February 2016 17:12:52 Ard Biesheuvel wrote:
> > +#ifdef CONFIG_DEBUG_RODATA
> >  /*
> >   * Without CONFIG_DEBUG_ALIGN_RODATA, __start_rodata_section_aligned will
> >   * be the first section-aligned location after __start_rodata. Otherwise,
> >   * it will be equal to __start_rodata.
> >   */
> >  __start_rodata_section_aligned = ALIGN(__start_rodata, 1 << SECTION_SHIFT);
> > +#endif
> >
> 
> Does
> 
> PROVIDE(__start_rodata_section_aligned = xxx);
> 
> do the trick as well? If it does, it's a bit cleaner.
> 

I would assume not, as the problem is that SECTION_SHIFT is a macro that
is not defined when the MMU is disabled.

	Arnd