linux-kernel - Re: [PATCH] iio: pressure: ms5611: select IIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBk0R-A5VEEd_D+kLKnyhc3nhrm0tv2JOkv0iqywGFtuw@mail.gmail.com>
Date:	Tue, 16 Feb 2016 20:03:29 +0200
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Daniel Baluta <daniel.baluta@...el.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: pressure: ms5611: select IIO_BUFFER

On Tue, Feb 16, 2016 at 4:55 PM, Arnd Bergmann <arnd@...db.de> wrote:
> The ms5611 driver started using the IIO_TRIGGERED_BUFFER infrastructure
> which in turn depend on IIO_BUFFER, and it produces a build error now
> if that is not enabled:
>
> warning: (... && MS5611 && ...) selects IIO_TRIGGERED_BUFFER which has unmet direct dependencies (IIO && IIO_BUFFER)
> buffer/industrialio-triggered-buffer.c: In function 'iio_triggered_buffer_setup':
> buffer/industrialio-triggered-buffer.c:58:2: error: implicit declaration of function 'iio_device_attach_buffer' [-Werror=implicit-function-declaration]
> pressure/ms5611_core.c: In function 'ms5611_trigger_handler':
> pressure/ms5611_core.c:193:2: error: implicit declaration of function 'iio_push_to_buffers_with_timestamp' [-Werror=implicit-function-declaration]
>
> This adds the second select.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 713bbb4efb9d ("iio: pressure: ms5611: Add triggered buffer support")

Acked-by: Daniel Baluta <daniel.baluta@...el.com>

> ---
>  drivers/iio/pressure/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index f15f66d6f527..31c0e1fd2202 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -69,6 +69,7 @@ config MPL3115
>
>  config MS5611
>         tristate "Measurement Specialties MS5611 pressure sensor driver"
> +       select IIO_BUFFER
>         select IIO_TRIGGERED_BUFFER
>         help
>           Say Y here to build support for the Measurement Specialties
> --
> 2.7.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html