linux-kernel - Re: [PATCH v2] [media] v4l2-async: Don't fail if registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Feb 2016 14:11:51 -0600
From:	Benoit Parrot <bparrot@...com>
To:	Javier Martinez Canillas <javier@....samsung.com>
CC:	<linux-kernel@...r.kernel.org>, Sakari Ailus <sakari.ailus@....fi>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Bryan Wu <cooloney@...il.com>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	<linux-media@...r.kernel.org>
Subject: Re: [PATCH v2] [media] v4l2-async: Don't fail if registered_async
 isn't implemented

Tested-by: Benoit Parrot <bparrot@...com>

Javier Martinez Canillas <javier@....samsung.com> wrote on Tue [2016-Feb-16 17:03:21 -0300]:
> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
> core calls the registered_async callback but if a sub-dev driver does
> not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
> should not be considered an error.
> 
> Reported-by: Benoit Parrot <bparrot@...com>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> 
> Changes in v2:
> - Check the return of v4l2_subdev_call (Benoit).
> 
>  drivers/media/v4l2-core/v4l2-async.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index 716bfd47daab..a4b224d92572 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -120,7 +120,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
>  	}
>  
>  	ret = v4l2_subdev_call(sd, core, registered_async);
> -	if (ret < 0) {
> +	if (ret < 0 && ret != -ENOIOCTLCMD) {
>  		if (notifier->unbind)
>  			notifier->unbind(notifier, sd, asd);
>  		return ret;
> -- 
> 2.5.0
>