linux-kernel - Re: [PATCH] zsmalloc: drop unused member 'mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217035558.GA15278@swordfish>
Date:	Wed, 17 Feb 2016 12:55:58 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	xuyiping <xuyiping@...ilicon.com>
Cc:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	YiPing Xu <xuyiping@...wei.com>, minchan@...nel.org,
	ngupta@...are.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, suzhuangluan@...ilicon.com,
	puck.chen@...ilicon.com, dan.zhao@...ilicon.com
Subject: Re: [PATCH] zsmalloc: drop unused member 'mapping_area->huge'

On (02/17/16 11:29), xuyiping wrote:
[..]
> 
> 	if (off + class->size <= PAGE_SIZE) {
> 
> for huge object, the code will get into this branch, there is no more huge
> object process in __zs_map_object.

correct, well, techically, it's not about huge objects, but objects that span
page boundaries. we can have objects of pretty small sizes being split between
pages, for example size:1536 and offset:3072, etc.

	-ss