linux-kernel - Re: [PATCH 1/2] cpufreq: ondemand: Simplify od

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217051218.GI2454@vireshk-i7>
Date:	Wed, 17 Feb 2016 10:42:18 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] cpufreq: ondemand: Simplify od_update() slightly

On 16-02-16, 21:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> Drop some lines of code from od_update() by arranging the statements
> in there in a more logical way.
> 
> No functional changes.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
>  drivers/cpufreq/cpufreq_ondemand.c |   11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 
> Index: linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> ===================================================================
> --- linux-pm.orig/drivers/cpufreq/cpufreq_ondemand.c
> +++ linux-pm/drivers/cpufreq/cpufreq_ondemand.c
> @@ -175,14 +175,11 @@ static void od_update(struct cpufreq_pol
>  		/* No longer fully busy, reset rate_mult */
>  		policy_dbs->rate_mult = 1;
>  
> -		if (!od_tuners->powersave_bias) {
> -			__cpufreq_driver_target(policy, freq_next,
> -					CPUFREQ_RELATION_C);
> -			return;
> -		}
> +		if (od_tuners->powersave_bias)
> +			freq_next = od_ops.powersave_bias_target(policy,
> +								 freq_next,
> +								 CPUFREQ_RELATION_L);
>  
> -		freq_next = od_ops.powersave_bias_target(policy, freq_next,
> -					CPUFREQ_RELATION_L);
>  		__cpufreq_driver_target(policy, freq_next, CPUFREQ_RELATION_C);
>  	}
>  }

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh