linux-kernel - Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06DA03E4-274B-4CD6-BE39-94018C378967@gmail.com>
Date:	Tue, 16 Feb 2016 22:30:48 -0800
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Clemens Gruber <clemens.gruber@...ruber.com>,
	netdev@...r.kernel.org
CC:	linux-kernel@...r.kernel.org,
	"David S . Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew@...n.ch>,
	Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH v3] phy: marvell: Fix and unify reg-init behavior

On February 15, 2016 2:46:45 PM PST, Clemens Gruber <clemens.gruber@...ruber.com> wrote:
>For the Marvell 88E1510, marvell_of_reg_init was called too late, in
>the
>config_aneg function.
>Since commit 113c74d83eef ("net: phy: turn carrier off on phy attach"),
>this lead to the link not coming up at boot anymore, due to the phy
>state machine being stuck at waiting for interrupts (off by default on
>the 88E1510).
>For seven other Marvell PHYs, marvell_of_reg_init was not called at
>all.
>
>Add a generic marvell_config_init function, which in turn calls
>marvell_of_reg_init.
>PHYs, which already have a specific config_init function with a call to
>marvell_of_reg_init, are left untouched. The generic
>marvell_config_init
>function is called for all the others, to get consistent behavior
>across
>all Marvell PHYs.
>
>Signed-off-by: Clemens Gruber <clemens.gruber@...ruber.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Thanks!

-- 
Florian