linux-kernel - Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 17:46:37 +0800
From:	Wei Ni <wni@...dia.com>
To:	Rob Herring <robh@...nel.org>
CC:	Sascha Hauer <s.hauer@...gutronix.de>,
	Thierry Reding <thierry.reding@...il.com>,
	Zhang Rui <rui.zhang@...el.com>, <MLongnecker@...dia.com>,
	Stephen Warren <swarren@...dotorg.org>,
	"Mikko Perttunen" <mikko.perttunen@...si.fi>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH V5 07/11] of: Add bindings of hw-trip-points for soctherm

Hi, Rob

On 2016年02月15日 15:15, Wei Ni wrote:
> Hi, Rob
> 
> On 2016年02月12日 22:42, Rob Herring wrote:
>> On Fri, Jan 29, 2016 at 2:47 AM, Wei Ni <wni@...dia.com> wrote:
>>> Add hw-trips sub-node for soctherm, which is
>>> used to describe the hardware trip points for
>>> each soctherm sensors.
>>
>> I still don't understand why you are doing something custom here.
>> What's wrong with what is defined in:
>>
>> Documentation/devicetree/bindings/thermal/thermal.txt

I think it's better to add a .set_trip_temp for of-thermal's
thermal_zone_of_device_ops{}, so that we can set trip points on hardware. I'm
preparing patches, and will send out next version.
Thanks for your comments.

> 
> In current thermal framework, it support to set trip points for the thermal
> zones, but this trip point is handled by SW, doesn't have callbacks to program
> the hardware.
> There had patches:
> [PATCH 12/16] thermal: thermal: Add support for hardware-tracked trip points,
> http://lists.infradead.org/pipermail/linux-mediatek/2015-May/000866.html,
> which can support to program hardware to set trip points, but it seems this
> series didn't be taken.
> So I add this hw-trip-points sub-node for soctherm.
> 
> Hi, Sascha Hauer
> 
> Thanks.
> Wei.
> 
>>
>> Rob
>>