linux-kernel - Re: [PATCHv4 3/7] eeprom: at24: extend driver to plug into the NVMEM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C452B8.5090503@linaro.org>
Date:	Wed, 17 Feb 2016 11:00:08 +0000
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Wolfram Sang <wsa@...-dreams.de>
Cc:	Andrew Lunn <andrew@...n.ch>, GregKH <greg@...ah.com>,
	maxime.ripard@...e-electrons.com, broonie@...nel.org, vz@...ia.com,
	fd@...com, linux-kernel@...r.kernel.org,
	pantelis.antoniou@...sulko.com, bgolaszewski@...libre.com
Subject: Re: [PATCHv4 3/7] eeprom: at24: extend driver to plug into the NVMEM
 framework



On 17/02/16 10:21, Wolfram Sang wrote:
> On Wed, Feb 17, 2016 at 10:17:39AM +0000, Srinivas Kandagatla wrote:
>>
>>
>> On 16/02/16 23:41, Andrew Lunn wrote:
>>> Add a regmap for accessing the EEPROM, and then use that with the
>>> NVMEM framework. Set the NVMEM config structure to enable backward, so
>>> that the 'eeprom' file in sys is provided by the framework.
>>>
>>> Signed-off-by: Andrew Lunn <andrew@...n.ch>
>>
>> This patch looks good to me, Please feel free to add my Ack.
>
> Please provide a proper Acked-by. Tools like 'patchwork' collect them
> automatically which means less manual work for me. Hint: Assign a
> keyboard macro to your text editor for that.

Agreed, I will take care of it next time.