linux-kernel - Re: [PATCHv4 5/7] eeprom: at25: extend driver to plug into the NVMEM framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C4796B.4030003@linaro.org>
Date:	Wed, 17 Feb 2016 13:45:15 +0000
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	Andrew Lunn <andrew@...n.ch>
Cc:	GregKH <greg@...ah.com>, maxime.ripard@...e-electrons.com,
	wsa@...-dreams.de, broonie@...nel.org, vz@...ia.com, fd@...com,
	linux-kernel@...r.kernel.org, pantelis.antoniou@...sulko.com,
	bgolaszewski@...libre.com
Subject: Re: [PATCHv4 5/7] eeprom: at25: extend driver to plug into the NVMEM
 framework



On 17/02/16 13:42, Andrew Lunn wrote:
>>> -	if (!(chip.flags & EE_READONLY)) {
>>> -		at25->bin.write = at25_bin_write;
>>> -		at25->bin.attr.mode |= S_IWUSR;
>>> -	}
>>
>> Above check is totally unused, probably remove it.
>
> Sorry, i don't understand. This check is being removed.

Oops, it think I replied to wrong patch, this comment was intended for 
"[PATCH 6/7] eeprom: 93xx46: extend driver to plug into the NVMEM framework"


--srini
>
>         Thanks
>    	  Andrew
>