linux-kernel - Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160216.203613.1959933915599102205.davem@davemloft.net>
Date:	Tue, 16 Feb 2016 20:36:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	arnd@...db.de
Cc:	linux-arm-kernel@...ts.infradead.org, helmut.buchsbaum@...il.com,
	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: spi_ks8995: include linux/gpio/consumer.h

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 12 Feb 2016 11:42:34 +0100

> The ks8995 phy driver just started using gpiod_* functions, which are
> declared in linux/gpio/consumer.h, not linux/gpio.h, resulting in a
> build failure in randconfig builds that do not have CONFIG_GPIOLIB
> enabled:
> 
> drivers/net/phy/spi_ks8995.c: In function 'ks8995_probe':
> drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
> 
> This changes the header inclusion so it builds in all configurations.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO")

Applied, thanks Arnd.