linux-kernel - Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217162810.GA2694@codeblueprint.co.uk>
Date:	Wed, 17 Feb 2016 16:28:10 +0000
From:	Matt Fleming <matt@...eblueprint.co.uk>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
	Stephane Eranian <eranian@...gle.com>,
	Vikas Shivappa <vikas.shivappa@...el.com>
Subject: Re: [PATCH] x86/perf/intel/cqm: Get rid of the silly for_each_cpu
 lookups

On Wed, 17 Feb, at 05:08:57PM, Thomas Gleixner wrote:
> On Wed, 17 Feb 2016, Thomas Gleixner wrote:
> 
> > CQM is a strict per package facility. Use the proper cpumasks to lookup the
> > readers.
> 
> Sorry for the noise. PEBKAC: quilt refresh missing. Correct version below.
> 
> Thanks,
> 
> 	tglx
> 
> 8<----------
> 
> Subject: x86/perf/cqm: Get rid of the silly for_each_cpu lookups
> From: Thomas Gleixner <tglx@...utronix.de>
> Date: Sun, 14 Feb 2016 23:09:06 +0100
> 
> CQM is a strict per package facility. Use the proper cpumasks to lookup the
> readers.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_cqm.c |   34 ++++++++++-------------------
>  1 file changed, 12 insertions(+), 22 deletions(-)

Right, I just could not make the connection between
topology_core_cpumask() and topology_physical_package_id() when I
wrote this code.

Reviewed-by: Matt Fleming <matt@...eblueprint.co.uk>