linux-kernel - Re: [PATCH v6 4/5] videobuf2-dc: Let drivers specify DMA attrs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 09:26:31 -0800
From:	Doug Anderson <dianders@...omium.org>
To:	Hans Verkuil <hverkuil@...all.nl>, Tomasz Figa <tfiga@...omium.org>
Cc:	Russell King <linux@....linux.org.uk>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Robin Murphy <robin.murphy@....com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Pawel Osciak <pawel@...iak.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 4/5] videobuf2-dc: Let drivers specify DMA attrs

Hans,

On Wed, Feb 17, 2016 at 9:00 AM, Hans Verkuil <hverkuil@...all.nl> wrote:
> Hi Doug,
>
> Is there any reason to think that different planes will need different
> DMA attrs? I ask because this patch series of mine:
>
> http://www.spinics.net/lists/linux-media/msg97522.html
>
> does away with allocating allocation contexts (struct vb2_dc_conf).
>
> For dma_attr this would mean that struct dma_attrs would probably be implemented
> as a struct dma_attrs pointer in the vb2_queue struct once I rebase that patch series
> on top of this patch. In other words, the same dma_attrs struct would be used for all
> planes.
>
> Second question: would specifying dma_attrs also make sense for videobuf2-dma-sg.c?

Those are all probably better questions for someone like Tomasz, who
authored ${SUBJECT} patch.  I mostly ended up touching this codepath
by going down the rabbit hole chasing a bug.  In my particular case I
was seeing that video was eating up all the large chunks in the system
needlessly and starving other memory users.  Using DMA attrs was the
logical way to indicate that we didn't need large chunks, so I used
it.  Other than that I'm totally unfamiliar with the video subsystem.


-Doug