linux-kernel - [PATCH] perf, tools, stat: Include asm/bug.h for WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Feb 2016 10:39:08 -0800
From:	Andi Kleen <andi@...stfloor.org>
To:	acme@...nel.org
Cc:	jolsa@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON

From: Andi Kleen <ak@...ux.intel.com>

In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change.
It may be that in some other setups asm/bug.h is implicitely included.
But always include it into builtin-stat.c

builtin-stat.c: In function ‘set_maps’:
builtin-stat.c:2126:6: error: implicit declaration of function ‘WARN_ONCE’ [-Werror=implicit-function-declaration]
  if (WARN_ONCE(st->maps_allocated, "stats double allocation\n"))
      ^
builtin-stat.c:2126:2: error: nested extern declaration of ‘WARN_ONCE’ [-Werror=nested-externs]
  if (WARN_ONCE(st->maps_allocated, "stats double allocation\n"))
  ^

Signed-off-by: Andi Kleen <ak@...ux.intel.com>
---
 tools/perf/builtin-stat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 6f24a96..a570e6d 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -60,6 +60,7 @@
 #include "util/thread_map.h"
 #include "util/counts.h"
 #include "util/group.h"
+#include "asm/bug.h"
 
 #include <api/fs/fs.h>
 #include <stdlib.h>
-- 
2.5.0