linux-kernel - Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217185621.GA9909@kernel.org>
Date:	Wed, 17 Feb 2016 15:56:21 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	jolsa@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON

Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu:
> > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change.
> > It may be that in some other setups asm/bug.h is implicitely included.
 
> Thanks, applying your fix, after making it build on acme/perf/core:

I take that back, it is already there:

[acme@...et linux]$ git blame tools/perf/builtin-stat.c  | grep -w bug\.h
ba6039b6c8fcc tools/perf/builtin-stat.c    (Jiri Olsa 2015-11-05 15:40:55 +0100 64) #include "asm/bug.h"
[acme@...et linux]$ git log --oneline -1 ba6039b6c8fcc
ba6039b6c8fc perf stat report: Add report command
[acme@...et linux]$ git tag --contains ba6039b6c8fcc
v4.5-rc1
v4.5-rc2
v4.5-rc3
v4.5-rc4
[acme@...et linux]$

- Arnaldo