linux-kernel - Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160217191059.GA27066@kroah.com>
Date:	Wed, 17 Feb 2016 11:10:59 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Victor Dodon <printesoi@...omium.org>
Cc:	linux-kernel@...r.kernel.org,
	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	linux-usb@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH v2] usb: storage: use usb_store_dbg instead of US_DEBUGPX

On Wed, Feb 17, 2016 at 10:42:37AM -0800, Victor Dodon wrote:
> The US_DEBUGPX macro uses printk without specifying a kernel log level, so
> the default kernel log level is used, which may not match LOGLEVEL_DEBUG
> used in usb_stor_dbg. Remove the macro and use usb_store_dbg instead.
> 
> Signed-off-by: Victor Dodon <printesoi@...omium.org>
> --
> Changes in v2:
>   - Completely remove the macro instead of using printk_emit
>   - Change all uses of US_DEBUGPX to usb_stor_dbg

Great!  Now can you get rid of the horrid USB_DEBUG() macro as well?  I
don't think that's really needed anymore (the frecom driver's usage can
just be removed entirely).

thanks,

greg k-h