linux-kernel - Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160217192444.GB9909@kernel.org>
Date:	Wed, 17 Feb 2016 16:24:44 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	jolsa@...nel.org, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON

Em Wed, Feb 17, 2016 at 08:15:35PM +0100, Andi Kleen escreveu:
> On Wed, Feb 17, 2016 at 03:56:21PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> > > Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu:
> > > > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change.
> > > > It may be that in some other setups asm/bug.h is implicitely included.
> >  
> > > Thanks, applying your fix, after making it build on acme/perf/core:
> > 
> > I take that back, it is already there:
> 
> Ok, but not in tip/perf/core. Can you push it there please?

Huh? I can't, this is not my tree, its Ingo's. But lemme check there...

[acme@...et linux]$ git remote update tip
Fetching tip
remote: Counting objects: 13, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 13 (delta 11), reused 0 (delta 0)
Unpacking objects: 100% (13/13), done.
>From git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
   5eaa0c926246..d7c926f699aa  master     -> tip/master
 + e2c90dd7e11e...65c23c65bee4 x86/efi    -> tip/x86/efi  (forced update)
   605a46ee8353..8f8e2aec9944  x86/platform -> tip/x86/platform
[acme@...et linux]$ git checkout -b aktest tip/perf/core
Branch aktest set up to track remote branch perf/core from tip.
Switched to a new branch 'aktest'
[acme@...et linux]$ git blame tools/perf/builtin-stat.c  | grep -w bug\.h
ba6039b6c8fcc tools/perf/builtin-stat.c                 (Jiri Olsa                2015-11-05 15:40:55 +0100   64) #include "asm/bug.h"
[acme@...et linux]$ git remote -v | grep tip
tip	git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (fetch)
tip	git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git (push)
[acme@...et linux]$