linux-kernel - Re: [PATCH] iio: health/afe4404: mark suspend/resume functions __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56C4CBB4.3050708@kernel.org>
Date:	Wed, 17 Feb 2016 19:36:20 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	"Andrew F . Davis" <afd@...com>, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: health/afe4404: mark suspend/resume functions
 __maybe_unused

On 15/02/16 09:19, Arnd Bergmann wrote:
> The newly added afe4404 driver implements suspend/resume using the
> SIMPLE_DEV_PM_OPS() macro, which leaves out references to the actual
> functions when CONFIG_PM is disabled, causing a harmless warning:
> 
> health/afe4404.c:509:12: error: 'afe4404_suspend' defined but not used
> health/afe4404.c:530:12: error: 'afe4404_resume' defined but not used
> 
> This marks the functions as __maybe_unused so we don't get those
> warnings.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 87aec56e27ef ("iio: health: Add driver for the TI AFE4404 heart monitor")
Applied to the togreg branch of iio.git.

Thanks,

Jonathan
> ---
>  drivers/iio/health/afe4404.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c
> index 0759268f37e0..5096a4643784 100644
> --- a/drivers/iio/health/afe4404.c
> +++ b/drivers/iio/health/afe4404.c
> @@ -477,7 +477,7 @@ static const struct of_device_id afe4404_of_match[] = {
>  MODULE_DEVICE_TABLE(of, afe4404_of_match);
>  #endif
>  
> -static int afe4404_suspend(struct device *dev)
> +static int __maybe_unused afe4404_suspend(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct afe4404_data *afe = iio_priv(indio_dev);
> @@ -498,7 +498,7 @@ static int afe4404_suspend(struct device *dev)
>  	return 0;
>  }
>  
> -static int afe4404_resume(struct device *dev)
> +static int __maybe_unused afe4404_resume(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct afe4404_data *afe = iio_priv(indio_dev);
>