lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 12:02:35 +0900 From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> To: Andrew Morton <akpm@...ux-foundation.org>, Minchan Kim <minchan@...nel.org> Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>, Sergey Senozhatsky <sergey.senozhatsky@...il.com> Subject: [RFC PATCH 2/3] zram: use zs_get_huge_class_size_watermark() zram should stop enforcing its own 'bad' object size watermark, and start using zs_get_huge_class_size_watermark(). zsmalloc really knows better. Drop `max_zpage_size' and use zs_get_huge_class_size_watermark() instead. Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com> --- drivers/block/zram/zram_drv.c | 2 +- drivers/block/zram/zram_drv.h | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 46055db..2621564 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -714,7 +714,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index, goto out; } src = zstrm->buffer; - if (unlikely(clen > max_zpage_size)) { + if (unlikely(clen > zs_get_huge_class_size_watermark())) { clen = PAGE_SIZE; if (is_partial_io(bvec)) src = uncmem; diff --git a/drivers/block/zram/zram_drv.h b/drivers/block/zram/zram_drv.h index 8e92339..8879161 100644 --- a/drivers/block/zram/zram_drv.h +++ b/drivers/block/zram/zram_drv.h @@ -23,12 +23,6 @@ /*-- Configurable parameters */ /* - * Pages that compress to size greater than this are stored - * uncompressed in memory. - */ -static const size_t max_zpage_size = PAGE_SIZE / 4 * 3; - -/* * NOTE: max_zpage_size must be less than or equal to: * ZS_MAX_ALLOC_SIZE. Otherwise, zs_malloc() would * always return failure. -- 2.7.1
Powered by blists - more mailing lists