linux-kernel - Re: [PATCH 9/12] cpufreq: governor: Move per-CPU data to the common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160218060821.GO2610@vireshk-i7>
Date:	Thu, 18 Feb 2016 11:38:21 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/12] cpufreq: governor: Move per-CPU data to the common
 code

On 18-02-16, 02:31, Rafael J. Wysocki wrote:
> @@ -464,21 +455,24 @@ static void od_set_powersave_bias(unsign
>  
>  	get_online_cpus();
>  	for_each_online_cpu(cpu) {
> +		struct cpufreq_policy *policy;
>  		struct policy_dbs_info *policy_dbs;
> +		struct dbs_data *dbs_data;
> +		struct od_dbs_tuners *od_tuners;
>  
>  		if (cpumask_test_cpu(cpu, &done))
>  			continue;
>  
> -		policy_dbs = per_cpu(od_cpu_dbs_info, cpu).cdbs.policy_dbs;
> +		policy = cpufreq_cpu_get_raw(cpu);

This is surely racy, as this might get called while governors are
getting exchanged. But this is racy today as well.

We should be using the list of policies present with the governors
here, with dbs_data->lock or something like that.


Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh