lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 09:06:56 +0100 From: Valentin Rothberg <valentin.rothberg@...teo.net> To: ldewangan@...dia.com Cc: kbuild-all@...org, alexandre.belloni@...e-electrons.com, javier@....samsung.com, k.kozlowski@...sung.com, cw00.choi@...sung.com, a.zummo@...ertech.it, linux-kernel@...r.kernel.org, rtc-linux@...glegroups.com, kbuild test robot <fengguang.wu@...el.com>, Valentin Rothberg <valentin.rothberg@...teo.net> Subject: [PATCH] rtc: max77686: fix irqf_oneshot.cocci warnings From: kbuild test robot <fengguang.wu@...el.com> Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Laxman Dewangan <ldewangan@...dia.com> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com> Signed-off-by: Valentin Rothberg <valentin.rothberg@...teo.net> --- drivers/rtc/rtc-max77686.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c index 5e924f3cde90..027ee7ebfff4 100644 --- a/drivers/rtc/rtc-max77686.c +++ b/drivers/rtc/rtc-max77686.c @@ -742,8 +742,8 @@ static int max77686_rtc_probe(struct platform_device *pdev) goto err_rtc; } - ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, 0, - "rtc-alarm1", info); + ret = request_threaded_irq(info->virq, NULL, max77686_rtc_alarm_irq, + IRQF_ONESHOT, "rtc-alarm1", info); if (ret < 0) { dev_err(&pdev->dev, "Failed to request alarm IRQ: %d: %d\n", info->virq, ret); -- 2.5.0
Powered by blists - more mailing lists