lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 09:12:53 +0100 From: Benjamin Tissoires <benjamin.tissoires@...hat.com> To: =?UTF-8?q?Cl=C3=A9ment=20Vuchener?= <clement.vuchener@...il.com> Cc: Jiri Kosina <jikos@...nel.org>, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH] HID: corsair: fix mapping of non-keyboard usages On Feb 16 2016 or thereabouts, =?UTF-8?q?Cl=C3=A9ment=20Vuchener?= wrote: > This fixes a bug where the Volume Up key was ignored because it uses the same usage code as G18. Special Corsair usage codes are in the keyboard page, other pages should be left to the generic driver. > > Signed-off-by: Clément Vuchener <clement.vuchener@...il.com> Looks good to me. Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com> Cheers, Benjamin > --- > drivers/hid/hid-corsair.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c > index 5855196..717704e 100644 > --- a/drivers/hid/hid-corsair.c > +++ b/drivers/hid/hid-corsair.c > @@ -595,6 +595,9 @@ static int corsair_input_mapping(struct hid_device *dev, > { > int gkey; > > + if ((usage->hid & HID_USAGE_PAGE) != HID_UP_KEYBOARD) > + return 0; > + > gkey = corsair_usage_to_gkey(usage->hid & HID_USAGE); > if (gkey != 0) { > hid_map_usage_clear(input, usage, bit, max, EV_KEY, > -- > 2.5.0 >
Powered by blists - more mailing lists