lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 09:01:36 +0100 From: Michal Simek <michal.simek@...inx.com> To: Peter Hurley <peter@...leysoftware.com>, Michal Simek <michal.simek@...inx.com>, <linux-arm-kernel@...ts.infradead.org>, "Arnd Bergmann" <arnd@...db.de>, Nicolas Pitre <nicolas.pitre@...aro.org> CC: Sören Brinkmann <soren.brinkmann@...inx.com>, <monstr@...str.eu>, Jiri Slaby <jslaby@...e.com>, <linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org> Subject: Re: [PATCH 2/3] serial: xuartps: Enable OF earlycon support Hi Peter, On 16.2.2016 17:33, Peter Hurley wrote: > Hi Michal, > > On 02/15/2016 08:05 AM, Michal Simek wrote: >> Support early console setup via DT for all listed compatible strings. >> >> Signed-off-by: Michal Simek <michal.simek@...inx.com> >> --- >> >> drivers/tty/serial/xilinx_uartps.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c >> index 009e0dbc12d2..6f5657766815 100644 >> --- a/drivers/tty/serial/xilinx_uartps.c >> +++ b/drivers/tty/serial/xilinx_uartps.c >> @@ -1094,6 +1094,9 @@ static int __init cdns_early_console_setup(struct earlycon_device *device, >> return 0; >> } >> EARLYCON_DECLARE(cdns, cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_a, "xlnx,xuartps", cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_b, "cdns,uart-r1p8", cdns_early_console_setup); >> +OF_EARLYCON_DECLARE(cdns_c, "cdns,uart-r1p12", cdns_early_console_setup); > > Earlycon now shares a common framework in linux-next. > > The EARLYCON_DECLARE() can be deleted and the OF_EARLYCON_DECLARE() > can all share the same earlycon name. iow, > > -EARLYCON_DECLARE(cdns, cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup); > +OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup); I have sent v2 and I have tested it. All looks good. Thanks for pointing me to that change. BTW: Is it normal that when earlycon support is enabled that the bootlog is copied again? All what was printed before bootconsole [xxx] disabled is printed twice. Or is this just bug in our driver? Thanks, Michal
Powered by blists - more mailing lists