lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 09:25:25 +0100 From: Michał Kępień <kernel@...pniu.pl> To: Pali Rohár <pali.rohar@...il.com> Cc: Matthew Garrett <mjg59@...f.ucam.org>, Darren Hart <dvhart@...radead.org>, Darek Stojaczyk <darek.stojaczyk@...il.com>, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 > > Please note that except for the first 5 entries, the keymap is sorted by > > event code in ascending order. > > I have prepared some patches which sort all event codes plus adds > missing comments... So after all dell patches are in Darren tree, I will > rewrite/rebase my and can send them. > > > If I understand correctly, doing what you ask would break that ordering: > > > > /* Dell Instant Launch key */ > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > /* Audio panel key */ > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > Is this acceptable? Or perhaps you had something else on your mind? > > Thats better, now we know which event is audio and which launch key. Ok, then I will do that in v4. -- Best regards, Michał Kępień
Powered by blists - more mailing lists