linux-kernel - Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3948917.nk5QvvnR6C@wuerfel>
Date:	Thu, 18 Feb 2016 10:05:06 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Andi Shyti <andi.shyti@...sung.com>,
	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, jacob.e.keller@...el.com
Subject: Re: [PATCH v2] regulator: s2mps11: Simplify expression used in BUILD_BUG_ON

On Thursday 18 February 2016 10:48:39 Krzysztof Kozlowski wrote:
> 
> Sure, it can be safely removed from s2mps11_info... but it won't affect
> this issue and this patch. Still the local variable would be used in
> probe leading to compiler optimization choices impacting BUILD_BUG_ON.

A local variable probably works fine, I can test that if we think that
would improve the code.

	Arnd