linux-kernel - Re: [PATCH] btrfs: fix ifnullfree.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 10:14:24 +0100
From:	David Sterba <dsterba@...e.cz>
To:	kbuild test robot <fengguang.wu@...el.com>
Cc:	Anand Jain <anand.jain@...cle.com>, kbuild-all@...org,
	"Chris Mason <chris.mason@...ionio.com> Chris Mason" <clm@...com>,
	Josef Bacik <jbacik@...com>, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs: fix ifnullfree.cocci warnings

On Wed, Feb 17, 2016 at 07:04:41PM +0800, kbuild test robot wrote:
> fs/btrfs/volumes.c:1886:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> CC: Anand Jain <anand.jain@...cle.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>

Thanks, applied to the respective branch.