lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 11:55:36 +1100 From: Julian Calaby <julian.calaby@...il.com> To: Amitoj Kaur Chawla <amitoj1606@...il.com> Cc: Amitkumar Karwar <akarwar@...vell.com>, Nishant Sarmukadam <nishants@...vell.com>, Kalle Valo <kvalo@...eaurora.org>, linux-wireless <linux-wireless@...r.kernel.org>, netdev <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH] mwifiex: Use to_delayed_work() Hi All, On Wed, Feb 17, 2016 at 11:33 PM, Amitoj Kaur Chawla <amitoj1606@...il.com> wrote: > Introduce the use of to_delayed_work() helper function instead of open > coding it with container_of() > > A simplified version of the Coccinelle semantic patch used to make > this change is: > > //<smpl> > @@ > expression a; > symbol work; > @@ > - container_of(a, struct delayed_work, work) > + to_delayed_work(a) > //</smpl> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com> Looks right to me. Reviewed-by: Julian Calaby <julian.calaby@...il.com> Thanks, > --- > drivers/net/wireless/marvell/mwifiex/11h.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/marvell/mwifiex/11h.c b/drivers/net/wireless/marvell/mwifiex/11h.c > index 71a1b58..81c60d0 100644 > --- a/drivers/net/wireless/marvell/mwifiex/11h.c > +++ b/drivers/net/wireless/marvell/mwifiex/11h.c > @@ -123,8 +123,7 @@ void mwifiex_11h_process_join(struct mwifiex_private *priv, u8 **buffer, > void mwifiex_dfs_cac_work_queue(struct work_struct *work) > { > struct cfg80211_chan_def chandef; > - struct delayed_work *delayed_work = > - container_of(work, struct delayed_work, work); > + struct delayed_work *delayed_work = to_delayed_work(work); > struct mwifiex_private *priv = > container_of(delayed_work, struct mwifiex_private, > dfs_cac_work); > @@ -289,8 +288,7 @@ int mwifiex_11h_handle_radar_detected(struct mwifiex_private *priv, > void mwifiex_dfs_chan_sw_work_queue(struct work_struct *work) > { > struct mwifiex_uap_bss_param *bss_cfg; > - struct delayed_work *delayed_work = > - container_of(work, struct delayed_work, work); > + struct delayed_work *delayed_work = to_delayed_work(work); > struct mwifiex_private *priv = > container_of(delayed_work, struct mwifiex_private, > dfs_chan_sw_work); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists