linux-kernel - Re: [PATCH] thermal: use %d to print S32 parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 18 Feb 2016 17:42:22 +0800
From:	Leo Yan <leo.yan@...aro.org>
To:	Javi Merino <javi.merino@....com>
Cc:	Zhang Rui <rui.zhang@...el.com>,
	Eduardo Valentin <edubezval@...il.com>,
	Punit Agrawal <punit.agrawal@....com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thermal: use %d to print S32 parameters

On Wed, Jan 13, 2016 at 09:22:16AM +0000, Javi Merino wrote:
> On Wed, Jan 13, 2016 at 04:33:56PM +0800, Leo Yan wrote:
> > Power allocator's parameters are S32 type, so use %d to print them.
> 
> Indeed.  The name of the macro is create_s32_tzp_attr(), it's
> explicitly saying that the parameter is signed!
> 
> > Signed-off-by: Leo Yan <leo.yan@...aro.org>
> 
> Acked-by: Javi Merino <javi.merino@....com>

Rui, Eduardo,

Could you help merge this patch as well?

Thanks,
Leo Yan

> 
> Cheers,
> Javi
> 
> > ---
> >  drivers/thermal/thermal_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index d9e525c..1335df2 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -931,7 +931,7 @@ static DEVICE_ATTR(sustainable_power, S_IWUSR | S_IRUGO, sustainable_power_show,
> >  	struct thermal_zone_device *tz = to_thermal_zone(dev);		\
> >  									\
> >  	if (tz->tzp)							\
> > -		return sprintf(buf, "%u\n", tz->tzp->name);		\
> > +		return sprintf(buf, "%d\n", tz->tzp->name);		\
> >  	else								\
> >  		return -EIO;						\
> >  	}								\
> > -- 
> > 1.9.1
> >