linux-kernel - Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to allocate with different value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56C5BEEA.7030004@redhat.com>
Date:	Thu, 18 Feb 2016 13:54:02 +0100
From:	Tomas Henzl <thenzl@...hat.com>
To:	Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>,
	JBottomley@...allels.com, jejb@...nel.org, hch@...radead.org
Cc:	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	Sathya.Prakash@...adcom.com, kashyap.desai@...adcom.com,
	krishnaraddi.mankani@...adcom.com, linux-kernel@...r.kernel.org,
	chaitra.basappa@...adcom.com, sreekanth.reddy@...adcom.com,
	Suganath prabu Subramani 
	<suganath-prabu.subramani@...gotech.com>
Subject: Re: [PATCH v2 1/2] mpt3sas: Free memory pools before retrying to
 allocate with different value.

On 18.2.2016 09:39, Suganath Prabu Subramani wrote:
> From: Suganath prabu Subramani <suganath-prabu.subramani@...gotech.com>
>
> Deallocate resources before reallocating of the same in retry_allocation
> path of _base_allocate_memory_pools()
>
> Signed-off-by: Suganath prabu Subramani <suganath-prabu.subramani@...gotech.com>
> Signed-off-by: Chaitra P B <chaitra.basappa@...adcom.com>
> ---
>  drivers/scsi/mpt3sas/mpt3sas_base.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
> index afdb13a..5bbbbf2 100644
> --- a/drivers/scsi/mpt3sas/mpt3sas_base.c
> +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
> @@ -3414,6 +3414,7 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc,  int sleep_flag)
>  			goto out;
>  		retry_sz = 64;
>  		ioc->hba_queue_depth -= retry_sz;
> +		_base_release_memory_pools(ioc);
>  		goto retry_allocation;
>  	}
>  

Reviewed-by: Tomas Henzl <thenzl@...hat.com>