linux-kernel - Re: [PATCH v1 2/8] mm, kasan: SLAB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=W7tH3MG9kEtPwZdA+ni3d1aSnFT8vkxXEVVQLsdiqZ+A@mail.gmail.com>
Date:	Thu, 18 Feb 2016 13:58:20 +0100
From:	Alexander Potapenko <glider@...gle.com>
To:	Joonsoo Kim <iamjoonsoo.kim@....com>
Cc:	kasan-dev@...glegroups.com, Christoph Lameter <cl@...ux.com>,
	linux-kernel@...r.kernel.org, Dmitriy Vyukov <dvyukov@...gle.com>,
	Andrey Ryabinin <ryabinin.a.a@...il.com>, linux-mm@...ck.org,
	Andrey Konovalov <adech.fo@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH v1 2/8] mm, kasan: SLAB support

However this info is meaningless without saved stack traces, which are
only introduced in the stackdepot patch (see "[PATCH v1 5/8] mm,
kasan: Stackdepot implementation. Enable stackdepot for SLAB")

On Mon, Feb 1, 2016 at 3:15 AM, Joonsoo Kim <iamjoonsoo.kim@....com> wrote:
> On Thu, Jan 28, 2016 at 02:29:42PM +0100, Alexander Potapenko wrote:
>> On Thu, Jan 28, 2016 at 1:37 PM, Alexander Potapenko <glider@...gle.com> wrote:
>> >
>> > On Jan 28, 2016 8:44 AM, "Joonsoo Kim" <iamjoonsoo.kim@....com> wrote:
>> >>
>> >> On Wed, Jan 27, 2016 at 07:25:07PM +0100, Alexander Potapenko wrote:
>> >> > This patch adds KASAN hooks to SLAB allocator.
>> >> >
>> >> > This patch is based on the "mm: kasan: unified support for SLUB and
>> >> > SLAB allocators" patch originally prepared by Dmitry Chernenkov.
>> >> >
>> >> > Signed-off-by: Alexander Potapenko <glider@...gle.com>
>> >> > ---
>> >> >  Documentation/kasan.txt  |  5 ++-
>> >>
>> >> ...
>> >>
>> >> > +#ifdef CONFIG_SLAB
>> >> > +struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache,
>> >> > +                                     const void *object)
>> >> > +{
>> >> > +     return (void *)object + cache->kasan_info.alloc_meta_offset;
>> >> > +}
>> >> > +
>> >> > +struct kasan_free_meta *get_free_info(struct kmem_cache *cache,
>> >> > +                                   const void *object)
>> >> > +{
>> >> > +     return (void *)object + cache->kasan_info.free_meta_offset;
>> >> > +}
>> >> > +#endif
>> >>
>> >> I cannot find the place to store stack info for free. get_free_info()
>> >> isn't used except print_object(). Plese let me know where.
>> >
>> > This is covered by other patches in this patchset.
>
> This should be covered by this patch. Stroing and printing free_info
> is already done on SLUB and it is meaningful without quarantain.
>
> Thanks.



-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den
Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please
do not forward it, please inform the sender, and please erase this
e-mail including any attachments. Thanks.