lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Feb 2016 14:40:20 +0100 From: Rafał Miłecki <zajec5@...il.com> To: Sudip Mukherjee <sudipm.mukherjee@...il.com> Cc: Kalle Valo <kvalo@...eaurora.org>, Network Development <netdev@...r.kernel.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, b43-dev <b43-dev@...ts.infradead.org> Subject: Re: [PATCH] b43: fix memory leak On 18 February 2016 at 13:34, Sudip Mukherjee <sudipm.mukherjee@...il.com> wrote: > From: Sudip Mukherjee <sudip@...torindia.org> > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and maybe use an additional label? Also may we be missing a proper free in b43_bcma_remove as well? Your patch subject could also be a bit more descriptive (e.g. what memory leak exactly is it).
Powered by blists - more mailing lists