linux-kernel - Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160218135751.GE7129@sirena.org.uk>
Date:	Thu, 18 Feb 2016 13:57:51 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jianqun Xu <jay.xu@...k-chips.com>
Cc:	Heiko Stuebner <heiko@...ech.de>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	jwerner@...omium.org, catalin.marinas@....com, will.deacon@....com,
	sboyd@...eaurora.org, linus.walleij@...aro.org,
	sjoerd.simons@...labora.co.uk, huangtao@...k-chips.com,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi

On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote:

> I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set
> the compatible like:
> - compatible: should be one of the followings
>    - "rockchip,rk3066-i2s": for rk3066
>    - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188
>    - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288
>    - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399
> and the driver only has
> static const struct of_device_id rockchip_i2s_match[] = {
> 	{ .compatible = "rockchip,rk3066-i2s", },
> 	{},
> };

> The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are
> keep different rules ?

No, that's just something that got missed in review and which should be
fixed.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)